Feature/proxy support #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable proxy support for those who are behind a corporate proxy.
mscharp
commented
Dec 9, 2020
| @@ -1414,7 +1417,7 @@ describe("Custom Domain Plugin", () => { | |||
| }); | |||
|
|
|||
| it("Domain summary failed", async () => { | |||
| AWS.mock("APIGateway", "getDomainName", (params, callback) => { | |||
| AWS.mock("ApiGatewayV2", "getDomainName", (params, callback) => { | |||
There was a problem hiding this comment.
I don't know why this was set to APIGateway to begin with. The actual code uses the ApiGatewayV2 to make the call to getDomainName. Tests worked fine before my changes ( I don't know why ), but after they would hang on this test until I updated the mock to ApiGatewayV2 to match the actual code.
I thought the getCredentials() call was only returning the credentials, but it seems to be returning the entire config object. Regardless, this now works.
|
Hey @rddimon. Not sure if you're the main owner of the plugin, but hoping I can get someone to look over the PR and merge if it looks good. Getting proxy support would be really handy! |
rddimon
approved these changes
Jan 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable proxy support for those who are behind a corporate proxy.
Fixes #388
Description of Issue Fixed
When behind a proxy, all calls to AWS services fail since they do not go through the proxy.
Changes proposed in this pull request:
When setting up the AWS services, pass in the httpOptions object that serverless creates.