Add support for mutual TLS authentication for regional APIs #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2022 22:48
…to fix codacy issue
|
Kudos, SonarCloud Quality Gate passed!
|
rddimon
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #503
Description of Issue Fixed
AWS added support for mutual TLS authentication to API Gateway regional APIs. Current version of serverless-domain-manager doesn't support it. This PR aims to solve that issue.
Changes proposed in this pull request:
CustomDomainextended with two optional properties:tlsTruststoreUriandtlsTruststoreVersion. WhenevertlsTruststoreUriis given, the plugin now creates domain names with mutual TLS enabled.tlsTruststoreUrimust be an s3 uri. The plugin now checks whether that file exists or not. If the plugin hasn't access to S3 (which may happen for several reasons), then it assumes the file exists and continues without failing.