Search SubjectAlternativeNames when finding cert #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove expired cert check as we don't need it now we have a cert status filter, add tests
|
Kudos, SonarCloud Quality Gate passed!
|
tomsaleeba
commented
Nov 26, 2022
| } | ||
| return null; |
There was a problem hiding this comment.
I removed the code around checking for expired certs because we don't need it with the cert status filter on line 6. Then I refactored what was left of the code.
I completely removed the call to describeCertificate because I realised all the details are already available from the summary list, so the extra API call is redundant.
tomsaleeba
commented
Nov 26, 2022
| for (const currCert of certificates) { | ||
| const allDomainsForCert = [ | ||
| currCert.DomainName, | ||
| ...(currCert.SubjectAlternativeNameSummaries || []), |
There was a problem hiding this comment.
This is where we include alt names in the search.
tomsaleeba
commented
Nov 26, 2022
| return; | ||
| } | ||
| throw new Error("Programmer error: didn't add new test mock data"); | ||
| }); |
There was a problem hiding this comment.
don't need this because it was related to the separate API call to check expiries.
rddimon
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (no ticket)
Description of Issue Fixed
Changes proposed in this pull request: