-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement property schema validation #74
Implement property schema validation #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @crunchie84, is there anything currently blocking this PR? I ask because this fix turns out to be one that my project is currently in need of.
Hey @danielharbor I contributed this fix a long time a go. Im currently not in the position to fix the static code analysis issue in the cicd so if the maintainers can address that its LGTM and shippable |
Thanks @crunchie84, we'll try to push it along. |
In serverless v2.7.0 schema validation of the serverless.yml has been implemented (see serverless/serverless#8422 (comment)) Based on this you can trigger errors when parameters are referenced which do not exist. This plugin relies on some custom properties in the serverless.yml which caused warnings. This commit appends the JSON schema as described in the README.md of this plugin
7e592f0
to
3300add
Compare
@danielharbor I've rebased the PR on the current state of |
This is great to hear @crunchie84. Thank you 馃. I'll also try to see if I can find a way to get the last item checked off:
@mluhovyi I do see that you've done quite a bit of work in this repo recently. Please any assistance you can offer in terms of getting the unchecked item above verified and/or reviewing the pull request would be much appreciated. |
FYI @g-bartoszek |
Thanks, @rddimon! |
Hi @danielharbor! It's not released yet |
Thanks for the heads up, @rddimon. We'll try to keep an eye out for the new release but please, in case you remember, we would appreciate an update here as well. Thanks so much! |
Fixes #73
TODOS