Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uncaught session storage security error handling #358

Merged
merged 3 commits into from
Feb 24, 2021

Conversation

jooohhn
Copy link
Contributor

@jooohhn jooohhn commented Feb 24, 2021

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: NO

Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there the risk that localstorage has the same permissioning issues?

@jooohhn
Copy link
Contributor Author

jooohhn commented Feb 24, 2021

No because we have a localStorage.js file that manages error handling

I was confused by our naming of it and thought its usage in metadata-storage.js referred to the actual browser API so I changed it to ampLocalStorage

@kelvin-lu
Copy link
Contributor

kelvin-lu commented Feb 24, 2021

Super cool. I wonder if it makes sense to put session storage with some compat flags like local storage, but not a blocker. I feel like I don't understand the session storage api quite well enough to say here.

@jooohhn jooohhn merged commit 560bb05 into main Feb 24, 2021
@jooohhn jooohhn deleted the fix-session-storage branch February 24, 2021 00:45
github-actions bot pushed a commit that referenced this pull request Feb 24, 2021
## [7.4.3](v7.4.2...v7.4.3) (2021-02-24)

### Bug Fixes

* Uncaught session storage security error handling ([#358](#358)) ([560bb05](560bb05))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught SecurityError: Failed to read the 'sessionStorage' property from 'Window
2 participants