Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call onError in init function #368

Merged
merged 3 commits into from
Mar 12, 2021
Merged

fix: call onError in init function #368

merged 3 commits into from
Mar 12, 2021

Commits on Mar 11, 2021

  1. AMP-32671 read in functions from options arg to amplitude client options

    AJ Horst authored and AJ Horst committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    cdecaf0 View commit details
    Browse the repository at this point in the history

  2. AMP-32671 call onError from args in amplitude client initialization 

    - the client's options may not have been initialized when an error occurs, so call onError from the args to make sure it's invoked regardless of when the error is thrown
    AJ Horst authored and AJ Horst committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    28856c8 View commit details
    Browse the repository at this point in the history

  3. AMP-32571 add unit test for onError

    AJ Horst authored and AJ Horst committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e2e98a0 View commit details
    Browse the repository at this point in the history