Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only take unique error logs and control limit #188

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

qingzhuozhen
Copy link
Collaborator

Summary

  • only take unique error logs
  • control how many error logs we send each time

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@qingzhuozhen qingzhuozhen requested a review from izaaz March 26, 2024 20:46
Copy link
Collaborator

@izaaz izaaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Rest LGTM. @crleona's questions are interesting. Its worth making sure swift and kotlin behave similarly at least.

@qingzhuozhen qingzhuozhen merged commit cca7d79 into main Mar 26, 2024
2 checks passed
@qingzhuozhen qingzhuozhen deleted the AMP-96433 branch March 26, 2024 22:17
github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
## [1.16.4](v1.16.3...v1.16.4) (2024-03-26)

### Bug Fixes

* only take unique error logs and control limit ([#188](#188)) ([cca7d79](cca7d79))
Copy link

🎉 This PR is included in version 1.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants