Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow none property value but not send #54

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: allow none property value but not send #54

merged 1 commit into from
Dec 12, 2023

Conversation

liuyang1520
Copy link
Contributor

Summary

fix: allow none property value but not send

Related issue: #52

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@liuyang1520 liuyang1520 requested a review from a team December 12, 2023 22:38
justin-fiedler
justin-fiedler approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @liuyang1520 !

@liuyang1520 liuyang1520 merged commit 677ebe7 into main Dec 12, 2023
8 checks passed
@liuyang1520 liuyang1520 deleted the fix-none-property-value branch December 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-fiedler justin-fiedler justin-fiedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liuyang1520 @justin-fiedler