Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: React Native 0.72 deprecation warning #164

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Jun 22, 2023

React Native 0.72 has update gradle things and has the following warning

> Task :amplitude_analytics-react-native:processDebugManifest
package="com.amplitude.reactnative" found in source AndroidManifest.xml: /home/johnf/work/gladly/mobile/node_modules/@amplitude/analytics-react-native/android/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

@justin-fiedler justin-fiedler changed the title Fix React Native 0.72 deprecation warning fix: React Native 0.72 deprecation warning Jun 29, 2023
Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnf for the fix.

@justin-fiedler justin-fiedler merged commit a0b1bb3 into amplitude:main Jun 29, 2023
5 of 6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.17.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants