fix: Don't use idfv as deviceID if disabled. (#133)

amplitude · Mar 12, 2024 · 76ef012 · 76ef012
1 parent 35f253d
commit 76ef012
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/Sources/Amplitude/Plugins/ContextPlugin.swift b/Sources/Amplitude/Plugins/ContextPlugin.swift
@@ -160,13 +160,13 @@ class ContextPlugin: BeforePlugin {
         if isValidDeviceId(deviceId) {
             return
         }
-        if deviceId == nil {
+        if deviceId == nil, amplitude?.configuration.trackingOptions.shouldTrackIDFV() ?? false {
             deviceId = staticContext["idfv"] as? String
         }
         if deviceId == nil {
             deviceId = NSUUID().uuidString
         }
-        _ = amplitude?.setDeviceId(deviceId: deviceId)
+        amplitude?.setDeviceId(deviceId: deviceId)
     }
 
     func isValidDeviceId(_ deviceId: String?) -> Bool {

diff --git a/Tests/AmplitudeTests/AmplitudeTests.swift b/Tests/AmplitudeTests/AmplitudeTests.swift
@@ -141,6 +141,17 @@ final class AmplitudeTests: XCTestCase {
         XCTAssertNil(lastEvent?.country)
     }
 
+    func testDeviceIdWithDisableIDFV() {
+        let configuration = Configuration(
+            apiKey: "testApiKeyDeviceIDWithDisableIDFV",
+            storageProvider: storage,
+            trackingOptions: TrackingOptions().disableTrackIDFV())
+
+        let amplitude = Amplitude(configuration: configuration)
+
+        XCTAssertNotEqual(amplitude.getDeviceId(), VendorSystem.current.identifierForVendor)
+    }
+
     func testSetUserId() {
         let amplitude = Amplitude(configuration: configurationWithFakeStorage)
         XCTAssertEqual(amplitude.getUserId(), nil)