feat: add middleware support #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
requested changes
Nov 11, 2021
| [client setServerZone:EU]; | ||
| XCTAssertEqualObjects(kAMPEventLogEuUrl, [client valueForKey:@"serverUrl"]); | ||
| } | ||
|
|
||
| - (void)testSetServerZoneWithoutUpdateServerUrl { | ||
| Amplitude *client = [Amplitude instanceWithName:@"eu_zone_2"]; | ||
| XCTAssertEqualObjects(kAMPEventLogUrl, [client valueForKey:@"serverUrl"]); | ||
| [client initializeApiKey:@"eu_api_ket"]; | ||
| [client initializeApiKey:@"eu_api_key"]; |
justin-fiedler
requested changes
Nov 12, 2021
justin-fiedler
approved these changes
Nov 16, 2021
yuhao900914
reviewed
Nov 22, 2021
| XCTAssertEqualObjects([event objectForKey:@"device_model"], deviceModel); | ||
| } | ||
|
|
||
| - (void)testRunWithNotPassMiddleware { |
There was a problem hiding this comment.
testRunWithoutPassMiddleware?
There was a problem hiding this comment.
NotPassMiddleware is the name of middleware, trying to test if it stops on further action
yuhao900914
approved these changes
Nov 22, 2021
|
🎉 This PR is included in version 8.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist