-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP-63100 Swift V2 example #268
Conversation
ios/swift/v2/AmpliSwiftSampleApp/AmpliSwiftSampleAppTests/AmpliTests.swift
Outdated
Show resolved
Hide resolved
ios/swift/v2/AmpliSwiftSampleApp/Shared/Plugins/LoggingPlugin.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @falconandy.
Running the tests in XCode gives an error.
I also get a warning in XCode:
/ios/swift/v2/AmpliSwiftSampleApp/AmpliSwiftSampleAppTests/AmpliTests.swift:118:22 Expression implicitly coerced from 'Any??' to 'Any?'
![image](https://private-user-images.githubusercontent.com/5790872/261121420-575e683e-1ec7-4a9b-a8a7-f621f6f8fa71.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA5MTk5NDcsIm5iZiI6MTcyMDkxOTY0NywicGF0aCI6Ii81NzkwODcyLzI2MTEyMTQyMC01NzVlNjgzZS0xZWM3LTRhOWItYThhNy1mNjIxZjZmOGZhNzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTRUMDExNDA3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWI1ZTRiNWJlZjUyNDUxNzVhYTNkMWE0NTEzMWJkZTRlODU2NmQ3NTk5ZTEyZDFmYjU0YjZiYjg2MGEwZGFjYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GXPo7BcNdTeWlmbOMzRgbTaLJeohxlg2XxecDJJoWc4)
ios/swift/v2/AmpliSwiftSampleApp/Shared/Plugins/LoggingPlugin.swift
Outdated
Show resolved
Hide resolved
ios/swift/v2/AmpliSwiftSampleApp/Shared/AmpliSwiftSampleAppApp.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@justin-fiedler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great locally. See nits.
@falconandy for consistency can you please also move the ObjC example to a |
Done |
Copy of Swift V1 example.