AMP-85465 Objective-C v2 app #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falconandy
force-pushed
the
AMP-85465-ampli-objc-v2-codegen
branch
2 times, most recently
from
79dc09b
to
b7fee27
Compare
falconandy
force-pushed
the
AMP-85465-ampli-objc-v2-codegen
branch
from
b7fee27
to
9cb0092
Compare
justin-fiedler
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Thanks @falconandy. Overall looks good. See comment about extending BaseEvent.
ios/objective-c/v2/AmpliObjectiveCSampleApp/AmpliObjectiveCSampleApp/Ampli/Ampli.m
Outdated
Show resolved
Hide resolved
falconandy
force-pushed
the
AMP-85465-ampli-objc-v2-codegen
branch
2 times, most recently
from
44e0ce7
to
e65097c
Compare
falconandy
force-pushed
the
AMP-85465-ampli-objc-v2-codegen
branch
from
4733411
to
ddb423f
Compare
ios/objective-c/v2/AmpliObjectiveCSampleApp/AmpliObjectiveCSampleApp/AppDelegate.m
Show resolved
Hide resolved
justin-fiedler
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example App for iOS Objective-C V2 runtime