Use requests PR

[rctbusk]

Description

useRequests is a react hook that takes in an array of query configs and returns two values. The first is an object containing values isFinished and isPending. isPending is true as long as any of the network calls made by useRequests is still in progress. isFinished is false as long all requests have not finished. The other value returned is a refresh function. This function when called forces all requests to be recalled no matter the response or status of the previous call.

Upgrade

This is meant to be a replacement to the v2 mapPropsToConfig functionality. Redux Query React did not have a good way of making batch requests in v3.

Architecture

This PR mostly copies both the current useRequest and v2 connect-request to make a hook for an array of query configs.

Feature Request

#158

[rctbusk]

@mili-confluent, do you have any thoughts on this?

[Myztiq]

👍 this is amazing! Should help with some important use-cases.

[mili-confluent]

I have a little concern here. Because I also wrote my own useRequests for my company. One edge case is if we first mount a component which has requests [A, B, C] and then we immediately unmount this component so that [A,B,C] will be cancelled (Assume [A,B,C] are all pending before unmounting). If you re-mount that component (for example, reopen that page), it will not request any [A,B,C] as they are already got cancelled. I am not sure whether this code will solve this problem

[mili-confluent]

Basically, I saw in useRequest we did some transform on queryConfig,

{retry: true}

https://github.com/amplitude/redux-query/blob/master/packages/redux-query-react/src/hooks/use-request.js#L36-L44

To solve this problem, maybe we also need to do this here?

[rctbusk]

Ah, I am currently setting {retry: true} in the use-memoized-query-configs.js. So the retry logic is there. This should be moved out and passed into the memoize function. It still has the {retry: true}, but the memoize should be agnostic to this, like how the current use-request.js works. I will change this.

[mili-confluent]

I think that's okay, as long as we add {retry: true}

[mili-confluent]

The version in someplace is 3.3.0-alpha.7 and someplace is 3.3.0-alpha.6, is that okay? Otherwise, LGTM, thank you.