New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved react from dependencies to devDependencies #56

Merged

ryanashcraft merged 1 commit into amplitude:master from crossfield:react-dev-dependency

Mar 31, 2017

Contributor

jeanregisser commented Mar 31, 2017

Hi,

React is already present as a peerDependency, which is good.
We don't need it as an explicit direct dependency.

I'm using React Native 0.43.0-rc.3 which works with React 16.0.0-alpha.3.
So ended up with 2 different React version in my node_modules.

Also I've got another PR coming which itself fixes another issue when you try to use redux-query with React Native. As seen in #32

Let me know what you think.


          Moved react from dependencies to devDependencies

7ebb396

Contributor

ryanashcraft commented Mar 31, 2017

@jeanregisser 👍 makes sense. thanks!

ryanashcraft merged commit 4fa4f44 into amplitude:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment