Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Add additional context for amp-accordion "Show"/"Hide" example #183

Closed
ericlindley-g opened this issue Jun 8, 2016 · 0 comments
Closed

Comments

@ericlindley-g
Copy link
Collaborator

Requesting additional context to demonstrate the use case more completely:

  1. Change heading text to "Show more"/"Show less"
  2. Add additional text above the accordion to demonstrate the snippet that gets completed by the expanded accordion (lorem ipsum should be fine for this)
  3. Add more text to the expanded accordion to demonstrate the longer, complete text that necessitates a "Show more"/"Show less" mechanic
  4. Reference that the CSS styles that change the text on expand/collapse appear above, in the code snippet.
sebastianbenz added a commit to sebastianbenz/amp-by-example that referenced this issue Jun 8, 2016
* demonstrate better show/hide
* show simple with single show button

Fixes ampproject#182,ampproject#183.
sebastianbenz added a commit to sebastianbenz/amp-by-example that referenced this issue Jun 8, 2016
* demonstrate better show/hide
* show simple with single show button

Fixes ampproject#182,ampproject#183.
sebastianbenz added a commit that referenced this issue Jun 8, 2016
* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.
juliantoledo added a commit that referenced this issue Jun 13, 2016
Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

add working example of amp-install-serviceworker (#156)

* add amp-install-serviceworker sample

* add comments on sw-precache

* add comment on how the SW works in this demo and how to confirm the result

* change to cache all image, video, html

* fix to point to original ABE page

* fix lint of gulpfile.js

* fix to cache only amp-install-serviceworker related files

* add comments on benefits of SW and changed only to cache amp-install-serviceworker

* nit

* modify comments and changed path to sw.js in relative path

* change gulpfile to organize the process to generate sw.js

* change gulpfile.js to directory put sw.js in dist dir

improve amp-social-share sample

* add amp facebook sample
* remove experimental flag
* add samples for all providers

Add amp-fx-flying-carpet sample (#169)

Change cursor to pointer on mouseover (#179)

Improve amp-accordion sample (#184)

* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.

Added ad to amp-fx-flying-carpet (#186)

optimize images

add AMP URL API embed

add AMP URL API Sample

Added sticky-ad example (#165)

Use a new ad (#187)

Remove the non-working link to create a fork

Fix typo in NewsArticle sample

disable directory file listings

Fixes #82

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button
juliantoledo added a commit that referenced this issue Jun 14, 2016
Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

add working example of amp-install-serviceworker (#156)

* add amp-install-serviceworker sample

* add comments on sw-precache

* add comment on how the SW works in this demo and how to confirm the result

* change to cache all image, video, html

* fix to point to original ABE page

* fix lint of gulpfile.js

* fix to cache only amp-install-serviceworker related files

* add comments on benefits of SW and changed only to cache amp-install-serviceworker

* nit

* modify comments and changed path to sw.js in relative path

* change gulpfile to organize the process to generate sw.js

* change gulpfile.js to directory put sw.js in dist dir

improve amp-social-share sample

* add amp facebook sample
* remove experimental flag
* add samples for all providers

Add amp-fx-flying-carpet sample (#169)

Change cursor to pointer on mouseover (#179)

Improve amp-accordion sample (#184)

* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.

Added ad to amp-fx-flying-carpet (#186)

optimize images

add AMP URL API embed

add AMP URL API Sample

Added sticky-ad example (#165)

Use a new ad (#187)

Remove the non-working link to create a fork

Fix typo in NewsArticle sample

disable directory file listings

Fixes #82

Remove AMP URL API Wrapper

* no longer needed as API now supports CORS
* rename view folder -> iframe
* increase result view size to match default result

add separator between amp-fx-flying-carpet and the text, add background and use another ad (#195)

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button
juliantoledo added a commit that referenced this issue Jun 14, 2016
Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

add working example of amp-install-serviceworker (#156)

* add amp-install-serviceworker sample

* add comments on sw-precache

* add comment on how the SW works in this demo and how to confirm the result

* change to cache all image, video, html

* fix to point to original ABE page

* fix lint of gulpfile.js

* fix to cache only amp-install-serviceworker related files

* add comments on benefits of SW and changed only to cache amp-install-serviceworker

* nit

* modify comments and changed path to sw.js in relative path

* change gulpfile to organize the process to generate sw.js

* change gulpfile.js to directory put sw.js in dist dir

improve amp-social-share sample

* add amp facebook sample
* remove experimental flag
* add samples for all providers

Add amp-fx-flying-carpet sample (#169)

Change cursor to pointer on mouseover (#179)

Improve amp-accordion sample (#184)

* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.

Added ad to amp-fx-flying-carpet (#186)

optimize images

add AMP URL API embed

add AMP URL API Sample

Added sticky-ad example (#165)

Use a new ad (#187)

Remove the non-working link to create a fork

Fix typo in NewsArticle sample

disable directory file listings

Fixes #82

Remove AMP URL API Wrapper

* no longer needed as API now supports CORS
* rename view folder -> iframe
* increase result view size to match default result

add separator between amp-fx-flying-carpet and the text, add background and use another ad (#195)

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button
juliantoledo added a commit that referenced this issue Jun 14, 2016
Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

add working example of amp-install-serviceworker (#156)

* add amp-install-serviceworker sample

* add comments on sw-precache

* add comment on how the SW works in this demo and how to confirm the result

* change to cache all image, video, html

* fix to point to original ABE page

* fix lint of gulpfile.js

* fix to cache only amp-install-serviceworker related files

* add comments on benefits of SW and changed only to cache amp-install-serviceworker

* nit

* modify comments and changed path to sw.js in relative path

* change gulpfile to organize the process to generate sw.js

* change gulpfile.js to directory put sw.js in dist dir

improve amp-social-share sample

* add amp facebook sample
* remove experimental flag
* add samples for all providers

Add amp-fx-flying-carpet sample (#169)

Change cursor to pointer on mouseover (#179)

Improve amp-accordion sample (#184)

* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.

Added ad to amp-fx-flying-carpet (#186)

optimize images

add AMP URL API embed

add AMP URL API Sample

Added sticky-ad example (#165)

Use a new ad (#187)

Remove the non-working link to create a fork

Fix typo in NewsArticle sample

disable directory file listings

Fixes #82

Remove AMP URL API Wrapper

* no longer needed as API now supports CORS
* rename view folder -> iframe
* increase result view size to match default result

add separator between amp-fx-flying-carpet and the text, add background and use another ad (#195)

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button
juliantoledo added a commit that referenced this issue Jun 14, 2016
Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

add working example of amp-install-serviceworker (#156)

* add amp-install-serviceworker sample

* add comments on sw-precache

* add comment on how the SW works in this demo and how to confirm the result

* change to cache all image, video, html

* fix to point to original ABE page

* fix lint of gulpfile.js

* fix to cache only amp-install-serviceworker related files

* add comments on benefits of SW and changed only to cache amp-install-serviceworker

* nit

* modify comments and changed path to sw.js in relative path

* change gulpfile to organize the process to generate sw.js

* change gulpfile.js to directory put sw.js in dist dir

improve amp-social-share sample

* add amp facebook sample
* remove experimental flag
* add samples for all providers

Add amp-fx-flying-carpet sample (#169)

Change cursor to pointer on mouseover (#179)

Improve amp-accordion sample (#184)

* demonstrate better show/hide
* show simple with single show button

Fixes #182,#183.

Added ad to amp-fx-flying-carpet (#186)

optimize images

add AMP URL API embed

add AMP URL API Sample

Added sticky-ad example (#165)

Use a new ad (#187)

Remove the non-working link to create a fork

Fix typo in NewsArticle sample

disable directory file listings

Fixes #82

Remove AMP URL API Wrapper

* no longer needed as API now supports CORS
* rename view folder -> iframe
* increase result view size to match default result

add separator between amp-fx-flying-carpet and the text, add background and use another ad (#195)

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button

New drawer menu using amp-sidebar

Cherry picked 3aed625
New header design:
* collapse header on mobile devices
* add AMP logo
* introduce hamburger button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants