Skip to content
This repository has been archived by the owner on Oct 22, 2019. It is now read-only.

Add metadata to examples #32

Closed
sebastianbenz opened this issue Feb 26, 2016 · 0 comments
Closed

Add metadata to examples #32

sebastianbenz opened this issue Feb 26, 2016 · 0 comments
Assignees
@juliantoledo

Comments

@sebastianbenz
Copy link
Collaborator

Make it possible to add metadata to examples via special comment tag, e.g.

<!---{ 
  experiment: true,
  component: amp-accordion
}--->

Metadata can contain arbitrary JSON. The DocumentParser should extract the metadata and add it to a new field in Document.

This is the foundation for:

//cc @jkingyens @juliantoledo does anyone of you want to tackle this?
@sebastianbenz sebastianbenz mentioned this issue Feb 26, 2016
Closed
@juliantoledo juliantoledo self-assigned this Mar 2, 2016
juliantoledo added a commit that referenced this issue Mar 3, 2016
@juliantoledo
Add metadata to examples #32
acb3ebd
juliantoledo added a commit that referenced this issue Mar 3, 2016
@juliantoledo
# This is a combination of 4 commits.
66cb819 
# The first commit's message is:
Add metadata to examples #32

# This is the 2nd commit message:

Fixing tasks/lib/DocumentParser.js
  69:1  error  Trailing spaces not allowed  no-trailing-spaces

# This is the 3rd commit message:

Add document.metadata tests

# This is the 4th commit message:

Test adding JSON metadata to document

Added another field to document.metadata test

Fix typo and add describe block

fix check for empty sample dir

correctly build example path

fix trailing whitespace

fix validator task

Added invalid document.metadata JSON test and trow error on JSON parsing
juliantoledo added a commit that referenced this issue Mar 3, 2016
@juliantoledo
Add metadata to examples #32
1675eb8 
-Fixing tasks/lib/DocumentParser.js 69:1 no-trailing-spaces
-Add document.metadata tests
-Test adding JSON metadata to document
-Added another field to document.metadata test
-Fix typo and add describe block
-fix trailing whitespace
-fix validator task
-Added invalid document.metadata JSON test and trow error on JSON parsing
sebastianbenz added a commit that referenced this issue Mar 3, 2016
@sebastianbenz
Merge pull request #51 from ampproject/metadata-to-examples
1efe0fa 
Add metadata to examples #32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@juliantoledo juliantoledo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbenz @juliantoledo