Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[owners] Support top-level owners file reviewerTeam property #522

Closed
rcebulko opened this issue Oct 8, 2019 · 1 comment · Fixed by ampproject/amphtml#24988
Closed

Comments

@rcebulko
Copy link
Contributor

rcebulko commented Oct 8, 2019

Per #499 , there is a need to have the owners check fail if a PR has approval from the OWNERS of the file, but not from someone in ampproject/reviewers-amphtml (or a comparable reviewer whitelist for other repositories). By integrating this into the owners check, we enable the repository to allow write-access to anyone.

The proposed solution is to allow a reviewerTeam property in the repository root OWNERS file, which can specify a GitHub team name. The owners check will report a failure for any PR unless at least one member of this team has reviewed it.

In any non-root owners file, this key will report an error and be ignored. If no such key is present in the repository root owners file, the condition will not be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant