Add reviewers team to root OWNERS file #24988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Oct 9, 2019
|
So the bot is basically looking for the team defined as "reviewerTeam" to determine which team must be included in the reviewers? And just to double check--if the PR author is in the reviewer team they'll be able to merge with just OWNERS approval from someone else (even if that other person is not a reviewer)? |
|
@mrjoro Yes; when the owners bot looks at PRs, it pretends the author implicitly gives an approving review. So, a PR authored by a reviewer, but approved by a non-reviewer, should pass. Note that it still relies on the GitHub setting to enforce that at least one reviewer approved the PR |
mrjoro
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines the reviewer team for the repository. Will cause the owners bot to enforce that every PR must have approval from at least one member of the
ampproject/reviewers-amphtmlteam.Closes ampproject/amp-github-apps#522