Deprecate PreloadHeroImage for OptimizeHeroImages #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added a commit
to ampproject/amp-wp
that referenced
this pull request
Jun 30, 2021
2 tasks
westonruter
requested changes
Jun 30, 2021
westonruter
reviewed
Jun 30, 2021
westonruter
reviewed
Jun 30, 2021
schlessera
force-pushed
the
add/55-optimize-hero-images-transformer
branch
from
af51a46
to
9f5be3d
Compare
Co-authored-by: Weston Ruter <westonruter@google.com>
pierlon
pushed a commit
to pierlon/amp-wp
that referenced
this pull request
Aug 15, 2021
dritter
added a commit
to dritter/amp-toolbox-php
that referenced
this pull request
Aug 31, 2021
As PreloadHeroImages is deprecated (see ampproject#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
OptimizeHeroImagestransformer and deprecates thePreloadHeroImagetransformer for it.The
PreloadHeroImagetransformer now produces a deprecation error and then forward thetransform()call to the newOptimizeHeroImagestransformer. This should provide a clean upgrade path for current consumers without breaking things.Note that we still keep the constants within
PreloadHeroImagearound, as they were not marked asprivatefor lack of language support at PHP 5.6+ and third-party code might thus directly reference them.Fixes #55