Prepare tests for running in process isolation #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
added
the
Testing
ediamin
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to run the tests with the
--process-isolationflag of PHPUnit, I noticed several problems.This PR fixes the ones that are obvious changes.
Even with these fixes, though, we cannot run the full test suite in process isolation, as there are multiple errors still. These are due to limitations in how PHPUnit runs the process isolation:
DOMDocumentobjects in data providers, as these cannot be serialized;STDOUTandSTDERRare being redirected into temporary memory streams, we cannot use checks likeposix_isatty(STDOUT), as these fail on the temporary streams./cc @swissspidy