Fix outdated PHPStan version in GHA workflow #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
added
the
Testing
schlessera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing repeated issues with caching of the PHPStan executable. The GHA cache cannot be invalidated, so the download for the PHPStan binary is sometimes stale for an undetermined time period.
This PR changes the workflow to use PHPStan as a Setup-PHP action tool, instead of from the Composer binary in the cache. The Composer binary is still left as a test dependency for local setups.
For easier debugging, this PR also outputs the version of PHPStan being used before running the analysis.