account for cases when parentNode and nextNode are undefined #1128
Conversation
| let err = null; | ||
|
|
||
| try { | ||
| await treeParser.parse(`<!doctype html> |
There was a problem hiding this comment.
Does this test ever fail?
There was a problem hiding this comment.
it would fail if the code I added isn't there
There was a problem hiding this comment.
ok, interesting. skipNodeAndChildren is only called from within transformers and these shouldn't be run when calling treeParser.parse.
will do |
|
@sebastianbenz I have gotten stuck on the tests. I am trying to reuse the same looped abstraction to test all of the transformers, and just unregister, mock, and reregister. But I am getting lost in jest - I pushed my current (broken) state, would you be able to take a look? |
| getDirectories(testConfig.testDir).forEach((testDir) => { | ||
| it(basename(testDir), (done) => runTests(testDir, done)); | ||
|
|
||
| it('works when skipNodeAndChildren returns null', function (done) { |
There was a problem hiding this comment.
I'd prefer not to add more tests here. Instead, we could add an end-to-end test here that runs a document with a template as last element through all transformers.
There was a problem hiding this comment.
sounds good
| let err = null; | ||
|
|
||
| try { | ||
| await treeParser.parse(`<!doctype html> |
There was a problem hiding this comment.
ok, interesting. skipNodeAndChildren is only called from within transformers and these shouldn't be run when calling treeParser.parse.
packages/optimizer/package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "htmlparser2": "5.0.1", | |||
| "https-proxy-agent": "5.0.0", | |||
| "lru-cache": "6.0.0", | |||
| "mock-require": "^3.0.3", | |||
There was a problem hiding this comment.
Do we still need this?
|
Can you revert the package lock to main. |
|
Thanks Patrick! The CI failures were unrelated to this PR. |
fix for #1121