More flexible hero images and blurry placeholders #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbenz
force-pushed
the
per-page-config
branch
2 times, most recently
from
2d3a325
to
5d3fb3c
Compare
patrickkettner
approved these changes
Jan 29, 2021
| class OptimizeHeroImage { | ||
| constructor(config) { | ||
| this.log = config.log; | ||
| this.enabled = config.optimizeHeroImages !== false || config.preloadHeroImage !== false; |
There was a problem hiding this comment.
should a warning be emitted about using preloadHeroImage?
packages/optimizer/README.md
Outdated
|
|
||
| #### `preloadHeroImage` | ||
|
|
||
| Deprecated, use `optimizeHeroImages` instead. |
There was a problem hiding this comment.
can you []() link to the section, please
packages/optimizer/README.md
Outdated
|
|
||
| If no `data-hero` attribute is present, AMP optimizer auto-detects hero images for `amp-img`, `amp-iframe`, `amp-video`, or `amp-video-iframe` and injects a `link rel=preload`. Image preload links will only be generated if there is none already existing. For `amp-img` elements, it will also server-side render the `img` element inside the `amp-img` element. This greatly improves image rendering performance and reduces the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/). | ||
| Hero images are optimized by server-side rendering the `img` element inside the `amp-img` element. This greatly improves image rendering performance and reduces the [largest contentful paint](https://web.dev/lcp/) (LCP) metric from [Core Web Vitals](https://web.dev/vitals/). |
There was a problem hiding this comment.
IANAL, but I think "This [can/may] greatly improve"/"normally reduces", etc is more accurate, no? or are we 100% certain of this
There was a problem hiding this comment.
I'm 100% certain, but might miss some corner cases. Rephrased.
| } | ||
|
|
||
| // check whether all required dependencies are installed | ||
| this.missingDependencies_ = false; |
There was a problem hiding this comment.
added comment
| appendChild(node, imgNode); | ||
| } | ||
| } | ||
| /* This transfomer has been deprecated, use OptimizeHeroImages.js instead */ |
There was a problem hiding this comment.
who is this message for? Should it be logged, rather than a comment?
There was a problem hiding this comment.
Added logging for the options. We don't have access to the log here.
This PR makes image optimization more flexible by making it possible to configure hero image count and blurry image placeholder generation on a per page basis. This PR also deprecates the preloadHeroImage option in favor of a new optimizeHeroImages option as preloading has been disabled in most cases (see #1132).
sebastianbenz
force-pushed
the
per-page-config
branch
from
f7c3bb8
to
b37e1f6
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes image optimization more flexible by making it possible to
configure hero image count and blurry image placeholder generation on a
per page basis.
This PR also deprecates the preloadHeroImage option in favor of a new
optimizeHeroImages option as preloading has been disabled in most cases (see
#1132).