fix docker image: transform environment variable values to boolean when possible #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mathieu-pousse
force-pushed
the
fix-env-var
branch
from
c3df0b5
to
2372633
Compare
mathieu-pousse
changed the title
samouri
approved these changes
Jun 15, 2021
| @@ -4,6 +4,10 @@ function objectFromEntries(arr) { | |||
| return Object.assign({}, ...Array.from(arr, ([k, v]) => ({[k]: v}))); | |||
| } | |||
|
|
|||
| function toBooleanIfPossible(value) { | |||
There was a problem hiding this comment.
nit: I'd prefer the fn name maybeParseBool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a fix for the docker image and its environment variables handling.
As the variables are strings, the checks in the optimizer fail when they are comparing 'true' with true.
The fix transform the string to a boolean value when possible.
This fixes the following command:
Let me know