Skip to content

Commit

Permalink
Keep amp-carousel on version 0.1 since 0.2 depends on experimental am…
Browse files Browse the repository at this point in the history
…p-base-carousel
  • Loading branch information
westonruter committed Aug 23, 2019
1 parent 4323eaa commit c93cb0b
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions includes/amp-helper-functions.php
Expand Up @@ -459,6 +459,15 @@ function amp_register_default_scripts( $wp_scripts ) {
}
}

if ( isset( $extensions['amp-carousel'] ) ) {
/*
* The 0.2 version of amp-carousel depends on the amp-base-carousel component, but this is still experimental.
* Also, the validator spec does not currently what base dependencies a given component has.
* @todo Revisit once amp-base-carousel is no longer experimental. Add support for obtaining a list of extensions that depend on other extensions to include in the script dependencies when registering below.
*/
$extensions['amp-carousel'] = '0.1';
}

foreach ( $extensions as $extension => $version ) {
$src = sprintf(
'https://cdn.ampproject.org/v0/%s-%s.js',
Expand Down

0 comments on commit c93cb0b

Please sign in to comment.