Test with WordPress 5.0, bump tested version to 5.0

[kienstra]

As a site owner, wanting to use the AMP plugin site with Wordpress 5.0, I want to know that the AMP plugin works with latest versions of Wordpress (ie. 5.0) and Gutenberg 4.2.0
Acceptance Criteria

• AC1. Test this plugin on the Paired mode staging site, which is now running WordPress 5.0-beta3, Gutenberg 4.2.0 (latest), and Twenty Nineteen
• AC2. Ensure visual and functional parity between AMP and non-AMP pages, using these guidelines
• AC3. Ensure the Compatibility Tool works like before (Implement improved error listing view #1361, Implement improved URL listing view #1362, Improved “Error Isolation” view #1364, Improved “single error” by URL view #1365) (There's no need to retest every AC on those issues, just confirm existing functionality)
• AC4. Once this is tested and the issues are resolved, bump the 'Tested up to' version in readme.txt and readme.md from 4.9 to 5.0
  https://github.com/Automattic/amp-wp/blob/469e99213d58d2af83915ca5924657648365bde7/readme.txt#L5

[kienstra]

In 'To do'

Hi @alcurrie,
This is now in the 'To do' column of v1.0. Feel free to add anything, or ask questions.

The next step is for me to ask @csossi to test this, using the Paired mode staging site.

[westonruter]

For the Twenty Nineteen aspects here, see #1587

[westonruter]

Merged PR regarding notice in compatibility tool: #1605.

[valtermild]

Fatal error: Uncaught Error: Call to undefined function gutenberg_get_jed_locale_data() in /home/v/valter8x/valter8x.beget.tech/public_html/wp-content/plugins/amp/includes/validation/class-amp-validation-manager.php:1919 Stack trace: #0 /home/v/valter8x/valter8x.beget.tech/public_html/wp-includes/class-wp-hook.php(286): AMP_Validation_Manager::enqueue_block_validation('') #1 /home/v/valter8x/valter8x.beget.tech/public_html,/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array) #2 /home/v/valter8x/valter8x.beget.tech/public_html/wp-includes/plugin.php(453): WP_Hook->do_action(Array) #3 /home/v/valter8x/valter8x.beget.tech/public_html/wp-admin/edit-form-blocks.php(383): do_action('enqueue_block_e...') #4 /home/v/valter8x/valter8x.beget.tech/public_html/wp-admin/post.php(160): include('/home/v/valter8...') #5 {main} thrown in /home/v/valter8x/valter8x.beget.tech/public_html/wp-content/plugins/amp/includes/validation/class-amp-validation-manager.php on line 1919

5.0-beta3-43883
Twenty NineteenVersion: 1.0
Version 1.0-RC2-20181105T185432Z-049b4cd2

[kienstra]

Hi @valtermild,
Thanks for letting us know about the fatal error.

Could you please help with some steps to reproduce the error?

[valtermild]

After installing WordPress version 5.0 and the amp plugin
Version 1.0-RC2-20181105T185432Z-049b4cd2 and the activation of the new default Twenty Nineteen theme. When you try to add a new post, this error occurs.

[alcurrie]

Thanks for the feedback @valtermild.
@kienstra I've updated the AC, above, but would it make sense to also update the AC to include testing with the new Twenty Nineteen theme and update the test site, to run not only the latest versions of Wordpress 5.0 ie. WordPress 5.0-beta3 and Gutenberg 4.2.0 but also the new default new default Twenty Nineteen theme once the issue in #1587 is merged?

[kienstra]

Good Idea

Hi @alcurrie,
Good idea. I updated a requirement to include testing on Twenty Nineteen. That's now the active theme on the 'Paired' site:

https://paired-ampconfdemo.pantheonsite.io/

[alcurrie]

@csossi - this is ready for your testing:
The following site is set up to test the WP 5.0:
https://paired-ampconfdemo.pantheonsite.io/ (This site is running AMP V1.0-RC, Twenty-nineteen Theme, Gutenberg 4.2.0 (not the newest) and WP 5.0beta 4

[csossi]

1. The "Geo-Test" Where Am I button works ONLY in the AMP version

2. There's a diff in image alignment on page. Amp version has:
   
   Non-Amp version has:
   

3. Diff in image rendering/resolution. Amp looks like this:
   
   Non-AMP looks like this:
   

4. These images on the Non-AMP site:
   
   Appear as a slider/marquee on the AMP version:
   

5. I seem to be unable to comment or reply to comments at https://paired-ampconfdemo.pantheonsite.io/2018/02/06/are-you-there-lebron-its-me-lebron-a-superstars-ultimate-pep-talk/?amp#respond (in both AMP and Non-AMP versions)

6. Blue area appearing at https://paired-ampconfdemo.pantheonsite.io/author/corinne-purtill/?amp. AMP looks like this:
   

Non-AMP looks like this:

7. "Follow Us" widget is empty on non-AMP pages:
   

8. Media Gallery Widget photos are poor quality in AMP version:
   

[kienstra]

Thanks For Testing
Moving To 'To Do' To Await Developmnet

Hi @csossi,
Thanks for testing this. I'm moving this to 'To Do' until there's work on the issues here.

[westonruter]

@valtermild The issue you identified has been fixed in #1612.