Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polldaddy shortcode callback triggered when shortcode not present #1620

Closed
emmalewis opened this issue Nov 16, 2018 · 7 comments
Closed

Polldaddy shortcode callback triggered when shortcode not present #1620

emmalewis opened this issue Nov 16, 2018 · 7 comments
Milestone

Comments

@emmalewis
Copy link

When using the plugin in conjunction with the Polldaddy plugin: https://wordpress.org/plugins/polldaddy/ the polldaddy shortcode callback function in wpcom/class-amp-polldaddy-embed.php is entered even when there is no polldaddy shortcode on the page. This results in a link at the bottom of the post content with text equal to the post title and url set to https://polldaddy.com.

@westonruter
Copy link
Member

@emmalewis what do you have in your post content to cause this problem? I can't replicate the problem.

@emmalewis
Copy link
Author

@westonruter Nothing. We have the polldaddy plugin activated but the problem is exclusively in posts that don't have a poll in them.

@westonruter
Copy link
Member

I have the Polldaddy plugin active on a site running v0.7.2 and I don't see any such link added to a post without a poll.

@emmalewis
Copy link
Author

@westonruter Thanks so much for investigating. We are also on v0.7.2, you can see an example of the link being output at the bottom of this post, immediately underneath the main content. https://scienceblog.cancerresearchuk.org/2017/02/10/3-of-the-toughest-questions-in-cancer-and-more-than-70-million-to-solve-them/amp/

@westonruter
Copy link
Member

In the non-AMP version of your post, there is a Polldaddy rating embed:

image

This is output to the page as:

<div class="pd-rating" id="pd_rating_holder_4922776_post_15110"></div>

So that is where the link is coming from.

You probably have your Rating settings as follows:

image

So the quick fix is to disable ratings.

@westonruter
Copy link
Member

A permanent fix can be found in #1621 which should be included as part of 1.0.

@westonruter westonruter added this to the v1.0 milestone Nov 16, 2018
@emmalewis
Copy link
Author

Great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants