New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-circuit polldaddy shortcode when no poll or survey supplied #1621

Merged
merged 1 commit into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Nov 16, 2018

Prevent showing a link when a rating embed is being output.

Aside: This logic should be moved to the Polldaddy Crowdsignal plugin and not be housed in the AMP plugin.

Before

image

After

image

Fixes #1620.

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Nov 17, 2018

Approved

Hi @westonruter,
This looks good.

This works as expected, assuming I understand it correctly.

This fixes the behavior when the shortcode doesn't have a poll or survey attribute, like if it's simply [polldaddy]

Before

polldaddy-before

After

polldaddy-after

@westonruter westonruter merged commit 2860b77 into 1.0 Nov 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/polldaddy-ratings branch Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment