Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Nineteen: Featured image in post list does not appear properly #1656

Closed
westonruter opened this issue Nov 26, 2018 · 5 comments
Closed
Assignees

Comments

@westonruter
Copy link
Member

The featured image used appearing on a post list such as at https://2019-theme.amp-wp.org/ does not render properly:

image

There is an unexpected gap in the right side of the image.

See https://2019-theme.amp-wp.org/

@westonruter westonruter added the Bug Something isn't working label Nov 26, 2018
@westonruter westonruter added this to the v1.0 milestone Nov 26, 2018
@kienstra kienstra self-assigned this Nov 26, 2018
@kienstra kienstra added this to To do in v1.0 Nov 26, 2018
@kienstra
Copy link
Contributor

kienstra commented Nov 27, 2018

Question About Multidev Site

Hi @westonruter,
It looks like https://2019-theme.amp-wp.org/ is running 1.0-RC2. I can't reproduce this locally with 1.0, but it does appear with 1.0-RC2.

Would you have access to update the plugin on the multidev site? This might have been fixed by d7de7d1 in #1627.

Thanks, Weston 😄

@westonruter
Copy link
Member Author

Sure enough! I pushed up a new build of 1.0 including changes from RC3 and I don't see the problem anymore. 😅

@westonruter westonruter removed the Bug Something isn't working label Nov 27, 2018
@westonruter westonruter removed this from the v1.0 milestone Nov 27, 2018
@kienstra
Copy link
Contributor

Nice, thanks!

@westonruter
Copy link
Member Author

This is being revisited in #2036.

@kienstra
Copy link
Contributor

That's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants