Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to make it clear AMP plugin is now supporting both Website and Stories experiences #2567

Closed
westonruter opened this issue Jun 11, 2019 · 2 comments
Assignees
Labels
Documentation Documentation related tasks Enhancement New feature or improvement of an existing one P0 High priority
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Jun 11, 2019

The AMP plugin is no longer about just the Website: it also includes the Stories experience. The readme needs to be rewritten to make it clear that you can use the AMP plugin either to make an AMP Website or to just publish AMP Stories on your site, or both.

image

@westonruter
Copy link
Member Author

In v1.3 we should enable the Stories experience by default for new installs, as par #2550 (comment):

Good question. Not sure. Part of me says no because historically it would be adding something that people didn't ask for. Jetpack's custom content types are disabled by default.

I'd say leave it off by default now, and then we need to revamp the readme.txt to indicate that Stories is a key feature alongside Websites. (That's something that should be done prior to the 1.2 release.)

Then in 1.3 we can make it enabled by default, especially when Gutenberg is no longer a dependency, and when the Stories editor is more mature.

This would be doing:

--- a/includes/options/class-amp-options-manager.php
+++ b/includes/options/class-amp-options-manager.php
@@ -35,7 +35,7 @@ class AMP_Options_Manager {
 	 * @var array
 	 */
 	protected static $defaults = array(
-		'experiences'              => array( self::WEBSITE_EXPERIENCE ),
+		'experiences'              => array( self::WEBSITE_EXPERIENCE, self::STORIES_EXPERIENCE ),
 		'theme_support'            => 'disabled',
 		'supported_post_types'     => array( 'post' ),
 		'analytics'                => array(),

Again, this would only apply to new installs. Existing installs that already have the experiences option set, would not get the stories experience added to their site. But for new installs that have installed the plugin knowing that it features AMP for websites and stories, then they'll get both by default upon activation.

@swissspidy swissspidy added P0 High priority Documentation Documentation related tasks Enhancement New feature or improvement of an existing one AMP Stories labels Jun 12, 2019
@ThierryA ThierryA added this to the v1.2 milestone Jun 12, 2019
@westonruter
Copy link
Member Author

Done in #2571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related tasks Enhancement New feature or improvement of an existing one P0 High priority
Projects
None yet
Development

No branches or pull requests

4 participants