Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR check to require an assigned milestone prior to merging #5683

Closed
westonruter opened this issue Dec 10, 2020 · 2 comments
Closed

Add PR check to require an assigned milestone prior to merging #5683

westonruter opened this issue Dec 10, 2020 · 2 comments
Labels
Infrastructure Changes impacting testing infrastructure or build tooling WS:Core Work stream for Plugin core

Comments

@westonruter
Copy link
Member

Feature description

One of the suggestions in #2741 is:

Automatically assign the correct milestone to newly opened pull requests

This would not work so well for us because we'll have the next major milestone (x.y) along with the next minor milestone (x.y.z) that we need to decide between. Therefore, the most important thing is that a milestone needs to be specified. So a new check could be introduced that blocks merging of a PR until a milestone is assigned.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Infrastructure Changes impacting testing infrastructure or build tooling WS:Core Work stream for Plugin core labels Dec 10, 2020
@thelovekesh
Copy link
Collaborator

@westonruter Do we still need this?

@westonruter
Copy link
Member Author

It's not important, nah.

@westonruter westonruter closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes impacting testing infrastructure or build tooling WS:Core Work stream for Plugin core
Projects
None yet
Development

No branches or pull requests

2 participants