Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caption support to all amp-instagram embeds #822

Closed
hrkhal opened this issue Dec 7, 2017 · 1 comment
Closed

Add caption support to all amp-instagram embeds #822

hrkhal opened this issue Dec 7, 2017 · 1 comment
Milestone

Comments

@hrkhal
Copy link

@hrkhal hrkhal commented Dec 7, 2017

We've started to receive "Social Media Issues" emails from the Google Search Console because our amp-instagram embeds are missing captions which we display on the canonical by default.

They state: "Instagram posts embedded in the article are missing captions, which leads to context being lost."

Caption support for amp-instagram embeds was only added at the end of March this year.
ampproject/amphtml#8243

I propose making the necessary changes to amp-wp/includes/embeds/class-amp-instagram-embed.php to allow captions to be shown as default for all amp-instagram embeds to avoid future "Social Media Issues" for publishers.

If people are happy for this go ahead, I'll knock up the needed PR as soon as I can.

@westonruter
Copy link
Member

@westonruter westonruter commented Dec 8, 2017

Makes sense to me. Feel free to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants