Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AMP_QUERY_VAR constant and amp_query_var filter #945

Closed
westonruter opened this issue Feb 8, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@westonruter
Copy link
Member

commented Feb 8, 2018

Currently one is able to override the amp query var and endpoint to be something totally different:

https://github.com/Automattic/amp-wp/blob/c701b0b8614e4b454bf620950018d0f143796d3c/amp.php#L80-L88

This ability complicates some things because we have to wait until the theme has fully loaded before we can start looking for whether it is an AMP request or not.

I want to find out if this ability is actually being used. And if so, why. If it is not, then we should remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.