Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1083: Fetch external stylesheets (which aren't from whitelisted font CDNs) to include in amp-custom style #1174

merged 6 commits into from May 30, 2018


None yet
2 participants
Copy link

commented May 24, 2018

Fixes #1083.

The PR aims to make the following change:
If a non-whitelisted external stylesheet is found, try fetching it's content instead of just removing it.

@miina miina requested a review from westonruter May 24, 2018

westonruter added some commits May 30, 2018

Prevent doing remote stylesheet request during unit tests
Improve method for detecting whether cache is being used
Refactor imported stylesheet by replacing import rule with parsed CSS…
… list

* Ensures that the imported stylesheet will be cached and that the imported stylesheet will not be ignored when cached.
* Opt to base64-encode the calc() substitutions instead of using placeholders.

@westonruter westonruter added this to the v1.0 milestone May 30, 2018

@westonruter westonruter merged commit ab7204a into develop May 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@westonruter westonruter deleted the add/1083-fetch-external-stylesheets branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.