Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme support settings to admin screen; prevent serving dirty AMP #1199

Merged
merged 19 commits into from
Jun 8, 2018

Commits on Jun 6, 2018

  1. Configuration menu
    Copy the full SHA
    5a81073 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92424fb View commit details
    Browse the repository at this point in the history
  3. Add options for enabling amp theme support and configuring validation…

    … handling
    
    * Add admin settings for picking between disabled, paired, and native theme support. See #1196.
    * Add checkbox for automatically allowing tree shaking.
    * Add checkbox for automatically sanitizing all validation errors (including tree shaking).
    * Make explicitly clear that unaccepted validation errors will block rendering on AMP
    * Prevent serving dirty AMP by forcibly sanitizing all validation errors when amp_is_canonical(). See #1192.
    * When validation errors are automatically sanitized, ensure the terms' term_group is updated when re-checking.
    * Update AMP_Options_Manager::get_options() and to return default values.
    westonruter committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    555c079 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bae33e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5756d9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0068e79 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    be0557b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Configuration menu
    Copy the full SHA
    b94a830 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' of https://github.com/Automattic/amp-wp into a…

    …dd/admin-theme-support-options
    westonruter committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    0c339d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9971e22 View commit details
    Browse the repository at this point in the history
  4. Include HTML comment explaining that amphtml version is not available…

    … (and why)
    
    * Indicate the count of validation errors that are blocking AMP from being available.
    * Allow passing URL string in addition to amp_invalid_url post to AMP_Invalid_URL_Post_Type::get_invalid_url_validation_errors().
    westonruter committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    32a093e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f864d67 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Introduce "Flagged" status for validation errors which are Rejected b…

    …ut which are still forcibly sanitized
    
    * Fix PHP 5.3 error
    * Remove automatically setting amp_validation_error term_group based on forced status.
    * Let preview URL include development=1 flag.
    westonruter committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    d890b6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec95351 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    365d571 View commit details
    Browse the repository at this point in the history
  4. Improve UI to reflect sanitization status when required

    * Update post editor warnings to reflect when validation errors are forcibly sanitized but
    not explicitly accepted.
    * Allow tree shaking setting to be shown when in native mode.
    * Show notice when selecting native mode that sanitization is required.
    * Hide the preview button from the amp_invalid_url post if sanitization is required.
    westonruter committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    4aac14b View commit details
    Browse the repository at this point in the history
  5. Add AMP link to admin bar with indication of AMP status and re-valida…

    …te link
    
    Discontinue automatically-deleting an amp_invalid_url post when all errors are resolved.
    westonruter committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    5c6b486 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    616dad7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    421dc74 View commit details
    Browse the repository at this point in the history