Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version number from composer.json #1333

Merged
merged 2 commits into from Aug 12, 2018
Merged

Remove version number from composer.json #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e899574
Remove version number from composer.json
swissspidy Aug 12, 2018
e846b8e
Remove checking of version in composer.json since removed
westonruter Aug 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/verify-version-consistency.php
View file
Open in desktop
Expand Up @@ -16,7 +16,6 @@

$versions['package.json'] = json_decode( file_get_contents( dirname( __FILE__ ) . '/../package.json' ) )->version;
$versions['package-lock.json'] = json_decode( file_get_contents( dirname( __FILE__ ) . '/../package-lock.json' ) )->version;
$versions['composer.json'] = json_decode( file_get_contents( dirname( __FILE__ ) . '/../composer.json' ) )->version;

$readme_txt = file_get_contents( dirname( __FILE__ ) . '/../readme.txt' );
if ( ! preg_match( '/Stable tag:\s+(?P<version>\S+)/i', $readme_txt, $matches ) ) {
Expand Down
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Expand Up @@ -4,7 +4,6 @@
"homepage": "https://github.com/Automattic/amp-wp",
"type": "wordpress-plugin",
"license": "GPL-2.0",
"version": "1.0.0",
"repositories": [
{
"type": "vcs",
Expand Down
2 changes: 1 addition & 1 deletion contributing.md
View file
Open in desktop
Expand Up @@ -107,7 +107,7 @@ When you push a commit to your PR, Travis CI will run the PHPUnit tests and snif
Contributors who want to make a new release, follow these steps:

1. Do `npm run build-release` and install the `amp.zip` onto a normal WordPress install running a stable release build; do smoke test to ensure it works.
2. Bump plugin versions in `package.json` (×1), `package-lock.json` (×1, just do `npm install` first), `composer.json` (×1), and in `amp.php` (×2: the metadata block in the header and also the `AMP__VERSION` constant).
2. Bump plugin versions in `package.json` (×1), `package-lock.json` (×1, just do `npm install` first), and in `amp.php` (×2: the metadata block in the header and also the `AMP__VERSION` constant).
3. Add changelog entry to readme.
4. Draft blog post about the new release.
5. [Draft new release](https://github.com/Automattic/amp-wp/releases/new) on GitHub targeting the release branch, with the new plugin version as the tag and release title. Attaching the `amp.zip` build to the release. Include link to changelog in release tag.
Expand Down