Try: Use amp-mathml and amp-fit-text components in Gutenberg block edit function's React components #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
try/amp-in-react-components
branch
from
d4ec3bd
to
4f22bed
Compare
|
Quick note: we built our own amp-fit-text implementation for the AMP Stories editor. Maybe we could re-use that here as well? |
swissspidy
added
the
Stale
|
Created a new #3434 issue for amp-fit-text support in the editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to create content using AMP components, it is important that the AMP components be able to be rendered in the editing context. For the next generation editor of WordPress, Gutenberg, this means being able to use AMP components inside of React components, and that changes to the AMP components' attributes will cause the shadow DOM to dynamically update as expected.
This does work as expected
amp-mathmlcomponent:This may be because it doesn't have much shadow DOM to speak of, other than a single
iframechild.However, using the
amp-fit-textcomponent in React does not work as expected:Note that even though the
amp-fit-textcomponent'sheight,min-font-size, andmax-font-sizeattributes are being modified, the changes to them are not getting applied to the shadow DOM.