Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add embed support for Twitter timelines via new amp-twitter attributes #1396

Merged
merged 4 commits into from
Sep 4, 2018
Merged

Add embed support for Twitter timelines via new amp-twitter attributes #1396

merged 4 commits into from
Sep 4, 2018

Commits on Sep 4, 2018

  1. Add embed support for Twitter timelines via new amp-twitter attributes.

    Felix Arntz committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7e74f41 View commit details
    Browse the repository at this point in the history

  2. Fix invalid test case.

    Felix Arntz committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    6b95f6a View commit details
    Browse the repository at this point in the history

  3. Fix PHPCS issues in Twitter embed test.

    Felix Arntz committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    539f25b View commit details
    Browse the repository at this point in the history

  4. Fix Twitter timeline pattern to allow hyphens in slugs 

    * Remove unused function parameters.
* Use named capture groups in regular expressions.
    @westonruter
    westonruter committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7c150a0 View commit details
    Browse the repository at this point in the history