New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AMP status in admin bar reflects previewed accepted state #1409

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Sep 7, 2018

Given an invalid AMP page with validation errors as follows:

image

At the moment the admin bar looks as follows when the rejected validation error is flipped to accepted:

image

This change ensures that the status in the admin bar looks instead as:

image

@westonruter westonruter added this to the v1.0 milestone Sep 7, 2018

@westonruter westonruter requested a review from kienstra Sep 7, 2018

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Sep 7, 2018

Approved

Hi @westonruter,
Sorry for the delay.

This PR looks good, and works as expected. I also saw the checkbox appearing on accepting the final remaining validation error:

check-present

@westonruter westonruter merged commit 785afe6 into develop Sep 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/admin-bar-preview-amp-status branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment