Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.0-beta4 #1457

Merged
merged 2 commits into from Sep 24, 2018
Merged

Release 1.0-beta4 #1457

merged 2 commits into from Sep 24, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Sep 23, 2018 •
edited

  • Bump plugin versions in amp.php.
  • Update changelog in readme.txt with key changes.
  • Do npm run build and install the amp.zip onto a normal WordPress install running a stable release build; do smoke test to ensure it works.
  • Draft blog post about the new release.
  • Draft new pre-release on GitHub.

See https://github.com/Automattic/amp-wp/blob/develop/contributing.md#creating-a-release for items to be done prior to merging this PR.

@westonruter westonruter added this to the v1.0 milestone Sep 23, 2018
amedina
amedina approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!!!

@westonruter westonruter merged commit f2e315c into develop Sep 24, 2018
@westonruter westonruter deleted the release/1.0-beta4 branch September 24, 2018 12:03
@kienstra kienstra mentioned this pull request Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@westonruter @amedina