Add ETag to post-processor response with support for 304 status #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
Oct 3, 2018
includes/class-amp-theme-support.php
Outdated
| status_header( 304 ); | ||
| return ''; | ||
| } | ||
| AMP_HTTP::send_header( 'ETag', $response_cache_key ); |
There was a problem hiding this comment.
This header needs to be sent even when it is a 304 response.
westonruter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already computing a cache key for the post-processor results to be stored in the object cache. We can use this same cache key also for the
ETagof the response. Then a browser can serve theETagvalue in itsIf-None-Matchrequest header, and WordPress can short-circuit sending any response in favor of sendind304 Not Modified.