Do not show fallback source as active theme if no validation errors #1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
AMP_Validated_URL_Post_Type::render_sources_column()
where it will render the active theme with a(?)
after it (via 3be5767) when it can't find the source for an error, since in that case it is normally in the theme template itself. However, this was incorrectly showing the active theme when there were no validation errors at all to display in the summary at all. So this fix short-circuits the source summary display in this case.Before
After