Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Powered by WordPress in classic footer template #1837

Merged
merged 2 commits into from Jan 24, 2019

Conversation

westonruter
Copy link
Member

Fixes #1749, per #1749 (comment):

I'm wary of providing any option to disable the footer credits. Either the template should have the credits or it should be removed entirely. Decisions not options, and all. Since the AMP plugin isn't part of WordPress.com, I'm inclined to just removed it entirely, and on WordPress.com a mu-plugin can be added which re-adds the footer credits as required according to the policies there.

In the end, the footer credits only applies to the Classic mode. When using Native/Paired modes, the active theme's templates are used along with whatever they put in the footer, so this question becomes irrelevant. In any case, I'll also open a PR to remove the footer credits from the plugin for a future release.

Also adds missing wp_generator() to classic post template.

@googlebot googlebot added the cla: yes Signed the Google CLA label Jan 22, 2019
@westonruter westonruter added this to the v1.1 milestone Jan 22, 2019
@westonruter westonruter merged commit 1346e7c into develop Jan 24, 2019
@westonruter westonruter deleted the remove/classic-template-footer-credit branch January 24, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants