Update PHP-CSS-Parser to 8.3.0 #1842
Conversation
|
On second thought, now that there is a minimal difference between the upstream and the fork, we could now switch to using composer-patches. |
|
Nevertheless, this will need to happen after a new release of PHP-CSS-Parser is made. |
There was a problem hiding this comment.
Well, I thought I was kidding, but after reading your comments, I agree. Let's look into using composer-patches for this as well, at least check whether it's viable or whether our custom changes justify using a fork (which has the downside it needs to be separately maintained).
|
@sabberworm When do you anticipate 8.3.0 being released? |
…p-css-parser * 'develop' of github.com:ampproject/amp-wp: (114 commits) Update dependency fasterimage/fasterimage to v1.2.1 Run npm audit fix Improve phpdoc for comments sanitizer Deprecate the class-amp-comment-walker.php file and remove tests Fix updating comment item in amp-live-list based on new descendant comment Update dependency eslint to v5.14.1 Pin npm-run-all to 4.1.5; fix formatting of package.json Ignore build directory for eslint Add some more useful npm scripts Update contributing.md to reflect change in changelog management Remove obsolete assertion phpcs fixes Use comments sanitizer instead of custom walker Remove errant space Make comment walker filterable Update dependency grunt-wp-deploy to v2 phpcs adjustments Use reflection to test filters for all template types Borrow regex from get_query_template() Add required phpunit testsuite name ...
westonruter
changed the title
|
Happily 8.3.0 has been released: https://github.com/sabberworm/PHP-CSS-Parser/releases/tag/8.3.0 So I've update the PR to use Composer patching and eliminate the use of our fork. |
Updates sabberworm/php-css-parser to 8.3.0 with a patch for MyIntervals/PHP-CSS-Parser#138
The upstream changes include a couple of the changes that only existed in the XWP fork but which now have been merged upstream, including: