Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings screen updates #4998

Merged
merged 100 commits into from Jul 10, 2020
Merged

Settings screen updates #4998

merged 100 commits into from Jul 10, 2020

Commits on Jul 6, 2020

  1. Remove settings screen markup

    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a23e0b4 View commit details
    Browse the repository at this point in the history

  2. Refactor PHP classes for dependecy injection, update tests, setup adm… 

    …in screen
    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    a9e3d07 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9974b5c View commit details
    Browse the repository at this point in the history

  4. Welcome section

    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    0eea9d5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/4974-remove-close-on-finish-screen' into featur… 

    …e/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    5192f62 View commit details
    Browse the repository at this point in the history

  6. Settings screen parts

    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    398ef55 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/4974-remove-close-on-finish-screen' into featur… 

    …e/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    c0d28d0 View commit details
    Browse the repository at this point in the history

  8. Start on supported templates component

    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    4288269 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/develop' into feature/4704-setti… 

    …ngs-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    209222d View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Complete working settings screen without tests or reader themes

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    b9a3aa1 View commit details
    Browse the repository at this point in the history

  2. PHPUnit tests

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    aa32c6f View commit details
    Browse the repository at this point in the history

  3. Rename test class

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ce2ad8b View commit details
    Browse the repository at this point in the history

  4. Update e2e tests with minor fixes

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fe68e6b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/develop' into feature/4704-setti… 

    …ngs-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    336f684 View commit details
    Browse the repository at this point in the history

  6. Integrate reader theme seleection on settings page

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a16b9cf View commit details
    Browse the repository at this point in the history

  7. Resolve minor issues

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fdba128 View commit details
    Browse the repository at this point in the history

  8. Linting fixes

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4ed8e50 View commit details
    Browse the repository at this point in the history

  9. Improve tests

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e19f4c1 View commit details
    Browse the repository at this point in the history

  10. Add tests and fix static analysis

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    cdb8a17 View commit details
    Browse the repository at this point in the history

  11. Test fixes

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    316ef14 View commit details
    Browse the repository at this point in the history

  12. Fix phpcs issue

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2e29ad8 View commit details
    Browse the repository at this point in the history

  13. Copy update

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    d5b4ece View commit details
    Browse the repository at this point in the history

  14. Test fixes and style updates

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ec2d557 View commit details
    Browse the repository at this point in the history

  15. Move menu item last and update styles

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8aaadd9 View commit details
    Browse the repository at this point in the history

  16. Fix lint issue

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ddf8c99 View commit details
    Browse the repository at this point in the history

  17. Handle mode notices on the FE instead of BE

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    d689092 View commit details
    Browse the repository at this point in the history

  18. Fix a failing PHPunit test

    @johnwatkins0
    johnwatkins0 committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fe463ee View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Options page: improve handling of submit button disabled state

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    dfcc896 View commit details
    Browse the repository at this point in the history

  2. Show notices based on whether plugin was configured rather than wheth… 

    …er themesupport is set
    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4274149 View commit details
    Browse the repository at this point in the history

  3. Settings screen: minor JS updates

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    5c0aa8e View commit details
    Browse the repository at this point in the history

  4. E2E test fix

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2e996ba View commit details
    Browse the repository at this point in the history

  5. Style updates based on design review

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    2990917 View commit details
    Browse the repository at this point in the history

  6. Don't open wizard link in new tab

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d47b163 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/develop' into feature/4704-setti… 

    …ngs-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4ac1b0f View commit details
    Browse the repository at this point in the history

  8. Resolve additional conflicts with reader theme branch

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b05ffe6 View commit details
    Browse the repository at this point in the history

  9. Remove unneeded eslint ignore

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b646856 View commit details
    Browse the repository at this point in the history

  10. Remove old options menu class and notice that was moved to JS

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    480e393 View commit details
    Browse the repository at this point in the history

  11. Add needed use statements

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    1c81777 View commit details
    Browse the repository at this point in the history

  12. Move effect into onboarding wizard screen component

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    d00b249 View commit details
    Browse the repository at this point in the history

  13. Use temporary string to help tests pass

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    94545ca View commit details
    Browse the repository at this point in the history

  14. Static analysis fixes

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    83c2e01 View commit details
    Browse the repository at this point in the history

  15. Fix mock filename

    @johnwatkins0
    johnwatkins0 committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    4f7987d View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Refine mode recommendation notices on AMP settings screen

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4d36455 View commit details
    Browse the repository at this point in the history

  2. Settings screen: set max height on reader themes

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    da1977f View commit details
    Browse the repository at this point in the history

  3. Docblock fix 

    Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
    @johnwatkins0 @schlessera
    johnwatkins0 and schlessera committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c6f0fd7 View commit details
    Browse the repository at this point in the history

  4. Default fetching options to false

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b26e031 View commit details
    Browse the repository at this point in the history

  5. Only pass currently active theme notice to components that need it

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3dde065 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/4704-settings-screen-updates' of https://github… 

    ….com/ampproject/amp-wp into feature/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    af5ab7b View commit details
    Browse the repository at this point in the history

  7. Make relative import briefer 

    Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
    @johnwatkins0 @pierlon
    johnwatkins0 and pierlon committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f554e0e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'feature/4704-settings-screen-updates' of https://github… 

    ….com/ampproject/amp-wp into feature/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    df0f693 View commit details
    Browse the repository at this point in the history

  9. Remove unneeded defaultProps

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    151636d View commit details
    Browse the repository at this point in the history

  10. Update description and for details prop

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    79d4e15 View commit details
    Browse the repository at this point in the history

  11. Combine padding CSS rules 

    Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
    @johnwatkins0 @schlessera
    johnwatkins0 and schlessera committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6facd83 View commit details
    Browse the repository at this point in the history

  12. Small PHP comment fixes 

    Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
    @johnwatkins0 @pierlon @schlessera
    3 people committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8dae204 View commit details
    Browse the repository at this point in the history

  13. Undo debug code

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d6adb14 View commit details
    Browse the repository at this point in the history

  14. Move reader mode override component

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    376078b View commit details
    Browse the repository at this point in the history

  15. Add @todo above CSS var block

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    375d63b View commit details
    Browse the repository at this point in the history

  16. Make GoogleFonts class conditional

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5c5e452 View commit details
    Browse the repository at this point in the history

  17. Move ReaderThemes into DI architecture and minor improvements

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c695a2e View commit details
    Browse the repository at this point in the history

  18. Rename phpunit group

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    51a9ddb View commit details
    Browse the repository at this point in the history

  19. Remove check for "all" theme support declared in theme

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4881c2d View commit details
    Browse the repository at this point in the history

  20. Text updates

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    de82214 View commit details
    Browse the repository at this point in the history

  21. Update theme_support_args

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6e83093 View commit details
    Browse the repository at this point in the history

  22. Settings screen: show notices even if plugin is configured

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1d7c2e3 View commit details
    Browse the repository at this point in the history

  23. Remove obsolete imports

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c8cdcd0 View commit details
    Browse the repository at this point in the history

  24. Test fixes

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2856055 View commit details
    Browse the repository at this point in the history

  25. Linting fies

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1fdce43 View commit details
    Browse the repository at this point in the history

  26. Update test file with new class name

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2bc546c View commit details
    Browse the repository at this point in the history

  27. Cast filter result as array

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    796a896 View commit details
    Browse the repository at this point in the history

  28. PHPStan fixes

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6fa5132 View commit details
    Browse the repository at this point in the history

  29. Merge remote-tracking branch 'origin/develop' into feature/4704-setti… 

    …ngs-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    576b46e View commit details
    Browse the repository at this point in the history

  30. Update two more instances of changed class name

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a85667c View commit details
    Browse the repository at this point in the history

  31. Minor CSS updates from design feedback

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    966e796 View commit details
    Browse the repository at this point in the history

  32. Update class dependencies in PHPUnit instances

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    604cf0d View commit details
    Browse the repository at this point in the history

  33. Change HTMLElement to ElementName because the former exists globally

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f3c4148 View commit details
    Browse the repository at this point in the history

  34. Settings page: enhance conditional UI logic around supported template… 

    …s toggle
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1334179 View commit details
    Browse the repository at this point in the history

  35. Remove available_callback check and notice

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4fb339b View commit details
    Browse the repository at this point in the history

  36. Improve readability around mobile redirection visibility

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f45910b View commit details
    Browse the repository at this point in the history

  37. Increase width of status column in plugin suppression table

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d9bab74 View commit details
    Browse the repository at this point in the history

  38. Add todo indicating Plugin Suppression will be handled over REST in t… 

    …he future

Co-authored-by: Weston Ruter <westonruter@google.com>
    @johnwatkins0 @westonruter
    johnwatkins0 and westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e8bc432 View commit details
    Browse the repository at this point in the history

  39. Supported templates visibility updates

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e464cc2 View commit details
    Browse the repository at this point in the history

  40. Merge branch 'feature/4704-settings-screen-updates' of https://github… 

    ….com/ampproject/amp-wp into feature/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b8316bb View commit details
    Browse the repository at this point in the history

  41. Remove unnecessary default option provided via filter elsewhere 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @johnwatkins0 @westonruter
    johnwatkins0 and westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c55bdd9 View commit details
    Browse the repository at this point in the history

  42. Change ElementName to elementName and lint fixes

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4661ccb View commit details
    Browse the repository at this point in the history

  43. Merge branch 'feature/4704-settings-screen-updates' of https://github… 

    ….com/ampproject/amp-wp into feature/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c39c00b View commit details
    Browse the repository at this point in the history

  44. Restore ElementName

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3618745 View commit details
    Browse the repository at this point in the history

  45. Change registration action for GoogleFonts class

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    81b9a88 View commit details
    Browse the repository at this point in the history

  46. Comment formatting fix 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @johnwatkins0 @westonruter
    johnwatkins0 and westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b40767e View commit details
    Browse the repository at this point in the history

  47. Rename reader-mode-override.js

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    281c354 View commit details
    Browse the repository at this point in the history

  48. Remove redundant isset check

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c3d1d15 View commit details
    Browse the repository at this point in the history

  49. Escaping and minor updates to OptionsMenu.php 

    Co-authored-by: Weston Ruter <westonruter@google.com>
    @johnwatkins0 @westonruter
    johnwatkins0 and westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    55e26b9 View commit details
    Browse the repository at this point in the history

  50. Make details prop a string instead of a node

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    aaa6109 View commit details
    Browse the repository at this point in the history

  51. Merge branch 'feature/4704-settings-screen-updates' of https://github… 

    ….com/ampproject/amp-wp into feature/4704-settings-screen-updates
    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3505976 View commit details
    Browse the repository at this point in the history

  52. Add escaping to menu strings

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6f0a9c8 View commit details
    Browse the repository at this point in the history

  53. Remove unused variable

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    330f2c3 View commit details
    Browse the repository at this point in the history

  54. Restore supported templates fieldset without obsolete wrapper

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dc61532 View commit details
    Browse the repository at this point in the history

  55. Settings page CSS updates and test fixes

    @johnwatkins0
    johnwatkins0 committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f6c407c View commit details
    Browse the repository at this point in the history

  56. Remove dead code and update translator comment formatting

    @westonruter
    westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fea953b View commit details
    Browse the repository at this point in the history

  57. Open ecosystem page in a new window

    @westonruter
    westonruter committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e6ac291 View commit details
    Browse the repository at this point in the history

  58. Improve formatting of active theme notice 

    Co-authored-by: Pierre Gordon <16200219+pierlon@users.noreply.github.com>
    @westonruter @pierlon
    westonruter and pierlon committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f717920 View commit details
    Browse the repository at this point in the history