Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native img by default #6805

Merged
merged 2 commits into from Mar 14, 2022
Merged

Use native img by default #6805

merged 2 commits into from Mar 14, 2022

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Dec 22, 2021 •
edited

Summary

With amp-img being deprecated in favor of native img (ampproject/amphtml#30442), we can now finally stop using amp-img by default.

Depends on #6803.

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v2.3 milestone Dec 22, 2021
@westonruter westonruter added this to In Progress in Ongoing Dec 22, 2021
@westonruter westonruter mentioned this pull request Dec 22, 2021
Closed
@westonruter westonruter added the P0 High priority label Dec 23, 2021
@swissspidy swissspidy mentioned this pull request Jan 17, 2022
Closed
@westonruter westonruter mentioned this pull request Feb 7, 2022
Merged
2 tasks
Base automatically changed from update/amphtml-2112102136000 to develop March 3, 2022 04:47
@westonruter westonruter marked this pull request as ready for review March 14, 2022 18:02
@github-actions
Copy link
Contributor

Plugin builds for cca6c8e are ready 🛎️!

@westonruter
Copy link
Member Author

Merging this so it can soak in develop for a while to ensure it is fully baked.

@westonruter westonruter merged commit 7d20f14 into develop Mar 14, 2022
@westonruter westonruter deleted the update/native-img-by-default branch March 14, 2022 18:25
@westonruter westonruter moved this from In Progress to Ready for QA in Ongoing Mar 14, 2022
@westonruter westonruter mentioned this pull request Apr 7, 2022
Closed
@pooja-muchandikar
Copy link

Compared the changes of this PR and PR #7066 and found that the changes are done as per PR #7066.

And the changes are working as per #7066

By default amp-img is displayed and based on the toggle native img will be used. #7035 (comment)

@maitreyie-chavan maitreyie-chavan moved this from Ready for QA to QA Passed in Ongoing Jun 8, 2022
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes. P0 High priority
Projects
Ongoing
  
QA Passed
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@westonruter @pooja-muchandikar