Add AMP Settings label for gallery block toggle settings #7450

thelovekesh · 2023-02-06T19:33:10Z

Summary

Add a label for gallery block AMP carousel and lightbox toggle settings.

My code is tested and passes existing tests.
My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

github-actions · 2023-02-06T19:39:29Z

Plugin builds for d018967 are ready 🛎️!

assets/src/block-editor/helpers/index.js

pavanpatil1 · 2023-02-07T08:32:03Z

QA passed ✅

Cross-checked the issue, Now the label is properly visible for the AMP settings for the gallery block in advance settings option.

Add AMP Settings label for gallery block toggle settings

aead4b9

thelovekesh requested a review from westonruter February 6, 2023 19:33

thelovekesh self-assigned this Feb 6, 2023

thelovekesh added this to the v2.4 milestone Feb 6, 2023

thelovekesh added this to Ready for Review in Ongoing Feb 6, 2023

westonruter reviewed Feb 6, 2023

View reviewed changes

assets/src/block-editor/helpers/index.js Outdated Show resolved Hide resolved

thelovekesh added 2 commits February 7, 2023 03:20

Update AMP gallery block settings to be wrapped in <BaseControl />

46d4166

Merge branch 'develop' into add/amp-settings-label

d018967

westonruter approved these changes Feb 7, 2023

View reviewed changes

westonruter merged commit ec4e2f4 into develop Feb 7, 2023

westonruter deleted the add/amp-settings-label branch February 7, 2023 00:16

westonruter moved this from Ready for Review to Ready for QA in Ongoing Feb 7, 2023

westonruter unassigned thelovekesh Feb 7, 2023

thelovekesh moved this from Ready for QA to QA Passed in Ongoing Feb 7, 2023

westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023