Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReaderThemeSupportFeatures::theme_has_theme_json() with latest changes #7583

Merged
merged 3 commits into from Jul 11, 2023
Merged

Update ReaderThemeSupportFeatures::theme_has_theme_json() with latest changes #7583

merged 3 commits into from Jul 11, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Jul 11, 2023 •
edited

Summary

Fixes #7582

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

thelovekesh
thelovekesh commented Jul 11, 2023
View reviewed changes
src/ReaderThemeSupportFeatures.php
*
* @todo Replace `WP_DEBUG` once an "in development mode" check is available in Core.
*/
! ( defined( 'WP_DEBUG' ) && WP_DEBUG )
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter wp_get_development_mode() is recently introduced. So should we keep WP_DEBUG instead? Or we can add this function to this file and then use it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Yes, this should keep using WP_DEBUG. For sites with wp_get_development_mode(), they'll also have wp_theme_has_theme_json().

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited

Plugin builds for 95a0202 are ready 🛎️!

@westonruter westonruter added this to the v2.4.2 milestone Jul 11, 2023
@westonruter westonruter merged commit 79dee44 into develop Jul 11, 2023
35 checks passed
@westonruter westonruter deleted the update/wp-has-theme-json branch July 11, 2023 16:53
@thelovekesh thelovekesh added Bug Something isn't working Enhancement New feature or improvement of an existing one P2 Low priority Reader Mode WS:Core Work stream for Plugin core and removed Bug Something isn't working Enhancement New feature or improvement of an existing one P2 Low priority Reader Mode WS:Core Work stream for Plugin core labels Jul 13, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4.2
Development

Successfully merging this pull request may close these issues.

Update theme_has_theme_json to reflect WP 6.3 changes
2 participants
@thelovekesh @westonruter