Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NodeJS from 14 to 18 #7605

Merged
merged 9 commits into from Sep 1, 2023
Merged

Bump NodeJS from 14 to 18 #7605

merged 9 commits into from Sep 1, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Sep 1, 2023

Summary

  • Bump NodeJS from 14 to 16
  • Updates all NPM packages to the latest version

Fixes: #7599

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Plugin builds for 00a7241 are ready 🛎️!

if [ "$CURRENT_URL" != "http://localhost:$HOST_PORT" ]; then
wp option update home "http://localhost:$HOST_PORT" --quiet
wp option update siteurl "http://localhost:$HOST_PORT" --quiet
if [ "$CURRENT_URL" != "http://127.0.0.1:$HOST_PORT" ]; then
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for updating localhost with 127.0.0.1 - node-fetch/node-fetch#1624

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@westonruter westonruter merged commit 9bfb5b4 into develop Sep 1, 2023
34 of 35 checks passed
@westonruter westonruter deleted the bump/nodejs branch September 1, 2023 23:42
@westonruter westonruter added this to the v2.4.3 milestone Sep 1, 2023
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update node to 16 or 18
2 participants